Re: [PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09
From: Alexandre TORGUE
Date: Wed Jan 24 2024 - 04:57:48 EST
Hi Dario
On 1/23/24 19:48, Dario Binacchi wrote:
Hi Alexandre,
On Tue, Jan 23, 2024 at 5:36 PM Alexandre TORGUE
<alexandre.torgue@xxxxxxxxxxx> wrote:
Hi Dario
On 1/12/24 15:48, Dario Binacchi wrote:
As reported in the section 8.3 (i. e. Board revision history) of document
UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
related to the board revisions addressed by the patch:
- Board MB1225 revision B-03:
- Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
- Board MB1166 revision A-09:
- LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
The patch only adds the DTS support for the new display which belongs to
to the Novatek NT35510-based panel family.
Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
I still have YAML error. Do you have same on your side or maybe I missed
a dt-binding patch somewhere ?
/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
dsi@40016c00: Unevaluated properties are not allowed ('interrupts',
'panel-dsi@0' were unexpected)
from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml#
/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id:
http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#
What command do you run?
make -j16 CHECK_DTBS=y st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb
As reported by commit:
commit b81c8c3b8e3847a14bd83dd1de460df3efcb3329
Author: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
Date: Fri Oct 11 15:06:58 2019 +0200
ARM: dts: stm32: remove useless interrupt from dsi node for stm32f469
DSI driver doesn't use interrupt, remove it from the node since it
breaks yaml check.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxx
The fix could be to remove the 'interrupts' property from the dsi@40016c00
added by the patch [2/5] "ARM: dts: stm32: add DSI support on stm32f769"
Aside that, I just have a cosmetic question. Can we find a shorter name
for the board ? (not sure we can).
In the repo https://github.com/STMicroelectronics/STM32CubeF7.git
you can find this code:
#if defined(USE_STM32F769I_DISCO_REVB03)
/***********************NT35510
Initialization********************************/
/* Initialize the NT35510 LCD Display IC Driver (TechShine LCD IC Driver)
* depending on configuration set in 'hdsivideo_handle'.
*/
NT35510_Init(NT35510_FORMAT_RGB888, orientation);
/***********************End NT35510 Initialization****************************/
#else
/***********************OTM8009A Initialization********************************/
/* Initialize the OTM8009A LCD Display IC Driver (KoD LCD IC Driver)
* depending on configuration set in 'hdsivideo_handle'.
*/
OTM8009A_Init(OTM8009A_FORMAT_RGB888, orientation);
/***********************End OTM8009A Initialization****************************/
#endif /* USE_STM32F769I_DISCO_REVB03 */
in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery_lcd.c.
And the comment:
/* USE_STM32F769I_DISCO_REVB03 */ /* Applicable only for STM32F769I
DISCOVERY w/ MB1166-A09 LCD daughter board connected on */
in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery.h.
One possible approach might be to drop 'mb1225,' assuming that
'revb03' refers to it implicitly:
stm32f769-disco-revb03-mb1166-reva09
But any suggestion is welcome.
It is actually a tricky point. My position for MPU is to only support
the latest board revision (the one which is really sold). Idea behind is
to not have many board revisions to support. But I can understand that
some people using the "old" board would like to continue to work on it
with an upstream version. I 'm just not sure that this "old" version has
to be maintained.
Concerning the name, yes the first thing is to drop mb1225 (as disco =
MB1225). I would propose also to drop re "revb03" as there are no
changes regarding memory in this series.
regards
alex
I will wait for your opinion before sending version 9.
Thanks and regards,
Dario
Cheers
Alex
---
Changes in v8:
- Add Reviewed-by tag of Linus Walleij
- Add Reviewed-by tag of Raphael Gallais-Pou
Changes in v7:
- Replace .dts with .dtb in the Makefile
Changes in v6:
- Drop patches
- [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
- [7/8] drm/panel: nt35510: move hardwired parameters to configuration
- [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
because applied by the maintainer Linus Walleij
Changes in v5:
- Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().
Changes in v2:
- Change the status of panel_backlight node to "disabled"
- Delete backlight property from panel0 node.
- Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
in the same style as the original driver.
arch/arm/boot/dts/st/Makefile | 1 +
...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
2 files changed, 19 insertions(+)
create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
index 7892ad69b441..aa5b50d7ac61 100644
--- a/arch/arm/boot/dts/st/Makefile
+++ b/arch/arm/boot/dts/st/Makefile
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
stm32f469-disco.dtb \
stm32f746-disco.dtb \
stm32f769-disco.dtb \
+ stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
stm32429i-eval.dtb \
stm32746g-eval.dtb \
stm32h743i-eval.dtb \
diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
new file mode 100644
index 000000000000..014cac192375
--- /dev/null
+++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2023 Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
+ */
+
+#include "stm32f769-disco.dts"
+
+&panel_backlight {
+ status = "disabled";
+};
+
+&panel0 {
+ compatible = "frida,frd400b25025", "novatek,nt35510";
+ vddi-supply = <&vcc_3v3>;
+ vdd-supply = <&vcc_3v3>;
+ /delete-property/backlight;
+ /delete-property/power-supply;
+};