Re: [PATCH v2] iov_iter: streamline iovec/bvec alignment iteration
From: Keith Busch
Date: Wed Jan 24 2024 - 10:25:14 EST
On Tue, Jan 23, 2024 at 03:24:46PM -0700, Jens Axboe wrote:
> Rewrite the alignment checking iterators for iovec and bvec to be easier
> to read, and also significantly more compact in terms of generated code.
> This saves 270 bytes of text on x86-64 for me (with clang-18) and 224
> bytes on arm64 (with gcc-13).
>
> In profiles, also saves a bit of time as well for the same workload:
>
> 0.81% -0.18% [kernel.vmlinux] [k] iov_iter_aligned_bvec
> 0.48% -0.09% [kernel.vmlinux] [k] iov_iter_is_aligned
>
> which is a nice side benefit as well.
Looks good
Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>