Re: [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC

[Conor Dooley]

On Wed, Jan 24, 2024 at 05:59:36PM +0530, Siddharth Vadapalli wrote:
> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
> The controller on J722S SoC is similar to the one present on TI's AM64
> SoC, with the difference being that the controller on AM64 SoC supports
> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
> 
> Update the bindings with a new compatible for J722S SoC.
> 
> Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/sprujb3
> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Cheers,
Conor.

> ---
> 
> Hello,
> 
> This patch is based on linux-next tagged next-20240124.
> 
> v2:
> https://lore.kernel.org/r/20240122064457.664542-1-s-vadapalli@xxxxxx/
> Changes since v2:
> - Added fallback compatible for "ti,j722s-pcie-host" as
>   "ti,j721e-pcie-host" based on Conor's suggestion at:
>   https://lore.kernel.org/r/20240122-getting-drippy-bb22a0634092@spud/#t
> 
> v1:
> https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@xxxxxx/
> Changes since v1:
> - Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
>   thread.
> - Updated patch 3/3 which is the v1 for this patch by dropping the checks
>   for the "num-lanes" property and "max-link-speed" property since the PCI
>   driver already validates the "num-lanes" property.
> 
> Regards,
> Siddharth.
> 
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index b7a534cef24d..ac69deeaf1ee 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -23,6 +23,10 @@ properties:
>          items:
>            - const: ti,j7200-pcie-host
>            - const: ti,j721e-pcie-host
> +      - description: PCIe controller in J722S
> +        items:
> +          - const: ti,j722s-pcie-host
> +          - const: ti,j721e-pcie-host
>  
>    reg:
>      maxItems: 4
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature