Re: [PATCH v2 1/2] dt-bindings: arm: fsl: remove redundant company name
From: Hugo Villeneuve
Date: Wed Jan 24 2024 - 12:10:23 EST
On Wed, 24 Jan 2024 18:00:00 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 24/01/2024 17:46, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> >
> > Company name in compatible description appears twice, which is not really
> > helpful, so remove it from product name.
>
> It's just a string. There is no bug, at least you did not describe where
> the bug is.
Hi Krzysztof,
in fact the fix is based on comments you made in a
review for another board that I submitted:
https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@xxxxxxxxxx/
------------------
Company name appears twice, which is not really helpful. What's the true
name? Gateway EVK? Then keep only this.
-----------------
> This has probably little impact on user-space, but there could be such
> which actually reads compatibles and depends on them. Or bootloader or
> whatever. Therefore to me such cosmetic change of correct compatible is
> not worth ABI impact.
Yes, normally you would be right, but in this specific case, the board
is a prototype developped by my company and we are still at the
prototype stage, so there is zero ABI impact.
Maybe I can add this to the cover letter if you want me to submit a V3.
Hugo Villeneuve