Re: [PATCH 1/2] ARM: multi_v7_defconfig: Add more TI Keystone support

[Nishanth Menon]

On 10:59-20240124, Andrew Davis wrote:
> On 1/24/24 10:41 AM, Nishanth Menon wrote:
> > On 10:28-20240124, Andrew Davis wrote:
> > > The Keystone platforms used their own keystone_defconfig mostly to
> > > enable CONFIG_ARM_LPAE which could not be added to the multi_v7 config.
> > > Now that we have multi_v7_lpae_defconfig/lpae.config target we can and
> > > should use that defconfig for Keystone. Add the remaining must have
> > > options for Keystone support to multi_v7_defconfig.
> > > 
> > 
> > Please state bloat-o-meter impact on vmlinux.
> > 
> 
> $ ./scripts/bloat-o-meter build/vmlinux.baseline build/vmlinux
> add/remove: 387/0 grow/shrink: 6/0 up/down: 130945/0 (130945)
> ...
> Total: Before=22791863, After=22922808, chg +0.57%
> 
> 
> Seems half of that is TI_KEYSTONE_NETCP, if we don't think
> anyone will need nfs rootfs boot then we could make it a module:
> 
> 
> $ ./scripts/bloat-o-meter build/vmlinux.baseline build/vmlinux
> add/remove: 286/0 grow/shrink: 4/0 up/down: 64393/0 (64393)
> ...
> Total: Before=22791863, After=22856256, chg +0.28%

Please add that to commit message - the delta and rationale for the
config params you think we need to add in.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D