Re: [PATCH] nvmem: include bit index in cell sysfs file name

From: Miquel Raynal
Date: Wed Jan 24 2024 - 17:11:41 EST


Hi Arnd,

arnd@xxxxxxxx wrote on Wed, 24 Jan 2024 20:49:53 +0100:

> On Wed, Jan 24, 2024, at 18:22, Miquel Raynal wrote:
> > arnd@xxxxxxxxxx wrote on Mon, 22 Jan 2024 16:34:10 +0100:
> >
> >> From: Arnd Bergmann <arnd@xxxxxxxx>
> >>
> >>
> >> As far as I can tell, this is a problem for any device with multiple cells on
> >> different bits of the same address. Avoid the issue by changing the file name
> >> to include the first bit number.
> >
> > There is only one bit number right? We are talking about byte offsets
> > so this value can only range from 0 to 7? If we understand each other
> > correctly then why not, I'm fine with the extra ",0" thing.
>
> On the Apple M1, the nvmem registers are 32 bit wide, so the
> bit numbers can go up to 31. I can imagine some system using
> 64-bit registers, but it's unlikely to be higher than that.

In this case we will soon or later have a problem again. Can we include
the full offset of the bit and not just the first digit?

Thanks,
Miquèl