Re: [PATCH v2 1/2] arm64: dts: qcom: sm8650-mtp: add PM8010 regulators

[Konrad Dybcio]

On 1/24/24 20:15, David Collins wrote:
> On 1/23/24 00:49, Fenglin Wu via B4 Relay wrote:
> > From: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> >
> > Add PM8010 regulator device nodes for sm8650-mtp board.
> >
> > Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 118 ++++++++++++++++++++++++++++++++
> >   1 file changed, 118 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> > index 9d916edb1c73..3791971efee6 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> > @@ -428,6 +428,124 @@ vreg_l3i_1p2: ldo3 {
> >   						   RPMH_REGULATOR_MODE_HPM>;
> >   		};
> >   	};
> > +
> > +	regulators-6 {
> > +		compatible = "qcom,pm8010-rpmh-regulators";
> > +		qcom,pmic-id = "m";
> > +
> > +		vdd-l1-l2-supply = <&vreg_s1c_1p2>;
> > +		vdd-l3-l4-supply = <&vreg_bob2>;
> > +		vdd-l5-supply = <&vreg_s6c_1p8>;
> > +		vdd-l6-l7-supply = <&vreg_bob1>;
>
> Please replace this line with:
>
> vdd-l6-supply = <&vreg_bob1>;
> vdd-l7-supply = <&vreg_bob1>;
>
> > +
> > +		vreg_l1m_1p1: ldo1 {
> > +			regulator-name = "vreg_l1m_1p1";
> > +			regulator-min-microvolt = <1104000>;
> > +			regulator-max-microvolt = <1104000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>
> Optional:
> PM8010 L1 and L2 physically support LPM vs HPM configuration.
> Therefore, these lines could be added here to allow such configuration
> by software at runtime:
>
> regulator-allow-set-load;
> regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> 			   RPMH_REGULATOR_MODE_HPM>;

David,

I was under the impression that *all* RPMh regulators support
modesetting. Would that be an incorrect assumption to make?

Konrad