回复: [PATCH v1 2/2] irqchip: Add StarFive external interrupt controller

[Changhuang Liang]

Hi Philipp,

> On Mi, 2024-01-10 at 18:32 -0800, Changhuang Liang wrote:
> >[...]
> > +	irqc->rst = of_reset_control_get_by_index(intc, 0);
> 
> Please use of_reset_control_get_exclusive(intc, NULL) instead.
> 
> > +	if (IS_ERR(irqc->rst)) {
> > +		pr_err("Unable to get reset control\n");
> > +		ret = PTR_ERR(irqc->rst);
> 
> Consider printing the error code via %pe.
> 
> 

Thanks for your comments. Follow your advice, will change in next version.

regards
Changhuang