RE: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.

From: Ratheesh Kannoth
Date: Thu Jan 25 2024 - 00:03:59 EST


> From: Simon Horman <horms@xxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.


> I do understand that devm_free() exists, and there are cases where it makes
> sense. But I don't think devm_ is buying us anything here.
For graceful Error handling, this API makes sense.

> 1. Use kcalloc() instead of devm_kcalloc() 2. Not change kfree() calls to
> devm_kfree()
>
> Then you will end up with a smaller diff than the current patch.
> And it will address the problem described in the patch description.
ACK.