Re: [PATCH 3/3] gpiolib: add gpio_device_get_label() stub for !GPIOLIB

[Bartosz Golaszewski]

On Thu, Jan 25, 2024 at 9:16 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> Add empty stub of gpio_device_get_label() when GPIOLIB is not enabled.
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Fixes: d1f7728259ef ("gpiolib: provide gpio_device_get_label()")
> Suggested-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>
> Reset framework will need it:
> https://lore.kernel.org/oe-kbuild-all/202401250958.YksQmnWj-lkp@xxxxxxxxx/

And I suppose you'll want an immutable branch for that?

Bart

> ---
>  include/linux/gpio/driver.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index c1df7698edb0..7f75c9a51874 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -831,6 +831,12 @@ static inline int gpio_device_get_base(struct gpio_device *gdev)
>         return -ENODEV;
>  }
>
> +static inline const char *gpio_device_get_label(struct gpio_device *gdev)
> +{
> +       WARN_ON(1);
> +       return NULL;
> +}
> +
>  static inline int gpiochip_lock_as_irq(struct gpio_chip *gc,
>                                        unsigned int offset)
>  {
> --
> 2.34.1
>