Re: [PATCH 2/3] dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY schema

[Krzysztof Kozlowski]

On 19/01/2024 20:38, Cristian Ciocaltea wrote:
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      hdptxphy_grf: syscon@fd5e0000 {
> +        compatible = "rockchip,rk3588-hdptxphy-grf", "syscon";
> +        reg = <0x0 0xfd5e0000 0x0 0x100>;
> +      };

Drop node, not part of this binding.

> +
> +      hdptxphy: phy@fed60000 {

Drop label.

> +        compatible = "rockchip,rk3588-hdptx-phy";
> +        reg = <0x0 0xfed60000 0x0 0x2000>;
> +        clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>, <&cru PCLK_HDPTX0>;
> +        clock-names = "ref", "apb";

With these two changes:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof