Re: [PATCH net] net: dsa: mt7530: fix 10M/100M speed on MT7988 switch

[Arınç ÜNAL]

On 24/01/2024 08:17, Daniel Golle wrote:
> Setup PMCR port register for actual speed and duplex on internally
> connected PHYs of the MT7988 built-in switch. This fixes links with
> speeds other than 1000M.
>
> Fixes: ("110c18bfed414 net: dsa: mt7530: introduce driver for MT7988 built-in switch")
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Acked-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

I'm wondering why we manually set speed and duplex for these interface
modes in the first place. I don't how it works for
PHY_INTERFACE_MODE_INTERNAL but, at least for PHY_INTERFACE_MODE_TRGMII and
802.3z interfaces, phylink should already supply proper speed and duplex.

Arınç