Re: [PATCH v3] dt-bindings: fpga: Convert fpga-region binding to yaml

[Krzysztof Kozlowski]

On 20/01/2024 00:32, Rob Herring wrote:
> On Thu, Jan 18, 2024 at 01:34:16PM +0100, Michal Simek wrote:
>>
>>
>> On 1/17/24 22:47, Rob Herring wrote:
>>> On Wed, Jan 17, 2024 at 12:30:58PM +0100, Michal Simek wrote:

> 
>>>> +additionalProperties: true
>>>
>>> Why? This should only be used if another schema is going to include this
>>> one. That's not the case here.
>>
>> In v2 we discussed this with Krzysztof. I used pattern properties from
>> simple-bus.yaml in v2.
>>
>> https://lore.kernel.org/all/b2dd8bcd-1e23-4b68-b7b7-c01b034fc1fe@xxxxxxxxxx/
> 
> You didn't answer his question. You just picked up 
> 'additionalProperties: true' which is easy because it avoids 'problems'.
> 
> His question was is this a common schema referenced by other schemas? If 
> so, then use 'additionalProperties: true'. But it is not. You've 
> defined exactly what 'compatible' must be and that means it can't be a 
> common schema.

Yes, I missed that it has a compatible, so it is not expected to be
referenced from other schema, thus it should end with
'additionalProperties: false'.

Best regards,
Krzysztof