Re: [PATCH v2 2/4] reset: sophgo: add SG2042 reset generator driver

[Chen Wang]

On 2024/1/25 18:43, Philipp Zabel wrote:
> On Do, 2024-01-25 at 14:11 +0800, Chen Wang wrote:
> > From: Chen Wang <unicorn_wang@xxxxxxxxxxx>
> >
> > Reuse reset-simple driver for the Sophgo SG2042 reset generator.
> Subject prefix should be "reset: simple: "
Ok.
> > Signed-off-by: Chen Wang <unicorn_wang@xxxxxxxxxxx>
> > ---
> >   drivers/reset/Kconfig        |  1 +
> >   drivers/reset/reset-simple.c |  2 ++
> >   drivers/reset/sophgo/Kconfig | 10 ++++++++++
> >   3 files changed, 13 insertions(+)
> >   create mode 100644 drivers/reset/sophgo/Kconfig
> [...]
> > diff --git a/drivers/reset/sophgo/Kconfig b/drivers/reset/sophgo/Kconfig
> > new file mode 100644
> > index 000000000000..9ad96e49e1dd
> > --- /dev/null
> > +++ b/drivers/reset/sophgo/Kconfig
> > @@ -0,0 +1,10 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config RESET_SOPHGO_SG2042
> > +	bool "Sophgo SG2042 Reset Driver"
> > +	depends on ARCH_SOPHGO || COMPILE_TEST
> > +	select RESET_SIMPLE
> > +	default ARCH_SOPHGO
> > +	help
> > +	  This enables the reset controller driver for the Sophgo SG2042 SoC.
> > +
> Drop the Kconfig, just add a default y if ARCH_SOPHGO to RESET_SIMPLE.

hi，Philipp,

The purpose of my adding Kconfig is to consider that other socs under 
sophgo may not use RESET_SIMPLE. I'm worried that the coverage is too 
large when default y if ARCH_SOPHGO? What do you think?

Thanks,

Chen

> regards
> Philipp