Re: [PATCH 1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs
From: Lee Jones
Date: Thu Jan 25 2024 - 08:51:22 EST
On Tue, 09 Jan 2024 10:06:39 +0100, Arnd Bergmann wrote:
> These two functions have stub implementations that are called when
> NEW_LEDS and/or LEDS_CLASS are disabled, theorerically allowing drivers
> to optionally use the LED subsystem.
>
> However, this has never really worked because a built-in driver is
> unable to link against these functions if the LED class is in a loadable
> module. Heiner ran into this problem with a driver that newly gained
> a LEDS_CLASS dependency and suggested using an IS_REACHABLE() check.
>
> [...]
Applied, thanks!
[1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs
commit: c0b64609dada48907b04b48873ba052efa8f121d
[2/2] leds: make flash and multicolor dependencies unconditional
commit: 54602f38551e89b520611ffb9df05232d1bf73f8
--
Lee Jones [李琼斯]