Re: [PATCH 2/6] arm64: dts: qcom: sm8250: describe all PCI MSI interrupts

[Krzysztof Kozlowski]

On 25/01/2024 14:25, Dmitry Baryshkov wrote:
>>>                         interrupt-map = <0 0 0 1 &intc 0 434 IRQ_TYPE_LEVEL_HIGH>, /* int_a */
>>> @@ -2349,8 +2357,16 @@ pcie2: pcie@1c10000 {
>>>                         ranges = <0x01000000 0x0 0x00000000 0x0 0x64200000 0x0 0x100000>,
>>>                                  <0x02000000 0x0 0x64300000 0x0 0x64300000 0x0 0x3d00000>;
>>>
>>> -                       interrupts = <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>;
>>> -                       interrupt-names = "msi";
>>> +                       interrupts = <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       interrupt-names = "msi0", "msi1", "msi2", "msi3",
>>> +                                         "msi4", "msi5", "msi6", "msi7";
>>
>> This part looks a bit suspicious. All other platforms have these
>> interrupts in a continuous range.
> 
> Hmm, pcie1 interrupts are also not contiguous. Okay, fine then:
> 

Yeah, the other case has even two gaps.

Best regards,
Krzysztof