Re: [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver

[sakari.ailus@xxxxxxxxxxxxxxx]

Hi Zhi,

On Thu, Jan 25, 2024 at 02:24:52AM +0000, Zhi Mao (毛智) wrote:
> Hi Sakari
> 
> Thanks for your review code and comments.
> 
> On Tue, 2024-01-09 at 10:18 +0000, Sakari Ailus wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  Hi Zhi,
> > 
> > Thanks for the update.
> > 
> > On Tue, Jan 09, 2024 at 10:27:15AM +0800, Zhi Mao wrote:
> > > Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.
> > > 
> > > Signed-off-by: Zhi Mao <zhi.mao@xxxxxxxxxxxx>
> > > ---
> > >  drivers/media/i2c/Kconfig  |   10 +
> > >  drivers/media/i2c/Makefile |    1 +
> > >  drivers/media/i2c/gc08a3.c | 1467
> > ++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 1478 insertions(+)
> > >  create mode 100644 drivers/media/i2c/gc08a3.c
> > > 
> > > +for (i = 0; i < ARRAY_SIZE(link_freq_menu_items); i++) {
> > > +for (j = 0; j < bus_cfg.nr_of_link_frequencies; j++) {
> > > +if (link_freq_menu_items[i] ==
> > > +    bus_cfg.link_frequencies[j])
> > > +break;
> > > +}
> > > +
> > > +if (j == bus_cfg.nr_of_link_frequencies) {
> > > +dev_err(dev,
> > > +"no link frequency %lld supported, please check DT",
> > > +link_freq_menu_items[i]);
> > > +ret = -EINVAL;
> > > +goto done;
> > > +}
> > > +}
> > 
> > Please use v4l2_link_freq_to_bitmap() available here
> > <URL:
> > https://lore.kernel.org/linux-media/20240108151805.55584-2-sakari.ailus@xxxxxxxxxxxxxxx/T/#u>
> > ;.
> > We'll then merge both at the same time.
> > 
> 
> After got the latest linux kernel code base(tag: next-20240124), there
> seems to be not new API:v4l2_link_freq_to_bitmap() still.
> 
> Would you please let me know, how about the status about this API?

The patches are in my linuxtv.org tree's master branch now:

	https://git.linuxtv.org/sailus/media_tree.git/

-- 
Sakari Ailus