Re: [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping

From: Konrad Dybcio
Date: Thu Jan 25 2024 - 11:15:08 EST




On 1/25/24 14:02, neil.armstrong@xxxxxxxxxx wrote:
On 25/01/2024 11:47, Konrad Dybcio wrote:


On 1/25/24 11:43, Krzysztof Kozlowski wrote:
On 25/01/2024 10:59, Konrad Dybcio wrote:


On 1/24/24 17:45, Krzysztof Kozlowski wrote:
WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact
it is offset by one.  Correct it to fix recording via analogue
microphones.

The change is based on QRD8550 and should be correct here as well, but
was not tested on MTP8550.

Would this not be codec-and-not-board-specific, anyway?

Yes, indeed, it should be.

Should we move this to the driver and drop the then-uselesss
dt property?

Actually it's codec-and-soc specific, so I'm against dropping this.

Aaaah snap :(

Let's leave it as-is then.

Konrad