Re: [PATCH v2 19/28] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props

[Sam Protsenko]

On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@linaroorg> wrote:
>
> "samsung,spi-src-clk" and "num-cs" are optional dt properties. Downgrade
> the message from warning to debug message.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>

>  drivers/spi/spi-s3c64xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 692ccb7828f8..fc5fffc019e0 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1071,14 +1071,14 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev)
>                 return ERR_PTR(-ENOMEM);
>
>         if (of_property_read_u32(dev->of_node, "samsung,spi-src-clk", &temp)) {
> -               dev_warn(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n");
> +               dev_dbg(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n");
>                 sci->src_clk_nr = 0;
>         } else {
>                 sci->src_clk_nr = temp;
>         }
>
>         if (of_property_read_u32(dev->of_node, "num-cs", &temp)) {
> -               dev_warn(dev, "number of chip select lines not specified, assuming 1 chip select line\n");
> +               dev_dbg(dev, "number of chip select lines not specified, assuming 1 chip select line\n");
>                 sci->num_cs = 1;
>         } else {
>                 sci->num_cs = temp;
> --
> 2.43.0.429.g432eaa2c6b-goog
>