RE: [PATCH v2] x86/boot: Add a message about ignored early NMIs

[NOMURA JUNICHI(野村 淳一)]

> From: H. Peter Anvin <hpa@xxxxxxxxx>
> On 1/24/24 03:44, NOMURA JUNICHI(野村 淳一) wrote:
> >> From: Borislav Petkov <bp@xxxxxxxxx>
> >> On Mon, Jan 15, 2024 at 08:57:45AM +0000, NOMURA JUNICHI(野村 淳一) wrote:
> >>> +	if (spurious_nmi_count) {
> >>> +		error_putstr("Spurious early NMI ignored. Number of NMIs: 0x");
> >>> +		error_puthex(spurious_nmi_count);
> >>> +		error_putstr("\n");
> >>
> >> Uff, that's just silly:
> >>
> >> Spurious early NMIs ignored: 0x0000000000000017
> >>
> >> Would you like to add a error_putnum() or so in a prepatch which would
> >> make this output
> >>
> >> Spurious early NMIs ignored: 23.
> >>
> >> ?
> >>
> >> So that it is human readable and doesn't make me wonder what that hex
> >> value is supposed to mean?
> >
> > Yes, it would be nicer to print that way.  I used the existing error_puthex() just
> > to keep the patch minimal.  I will try to add error_putnum().
> >
> >> Btw, please use this version when sending next time:
> 
> Here is a *completely* untested patch for you...

Ah, I was preparing decimal only version but yours is much better.
I tested and it just works.

I would like to use yours as a prepatch.  May I have your signed-off-by?

--
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

Attachment: smime.p7s
Description: S/MIME cryptographic signature