Re: [PATCH v12 3/6] tracing: Add snapshot refcount

[kernel test robot]

Hi Vincent,

kernel test robot noticed the following build errors:

[auto build test ERROR on 4f1991a92cfe89096b2d1f5583a2e093bdd55c37]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Donnefort/ring-buffer-Zero-ring-buffer-sub-buffers/20240123-191131
base:   4f1991a92cfe89096b2d1f5583a2e093bdd55c37
patch link:    https://lore.kernel.org/r/20240123110757.3657908-4-vdonnefort%40google.com
patch subject: [PATCH v12 3/6] tracing: Add snapshot refcount
config: i386-randconfig-012-20240126 (https://download.01.org/0day-ci/archive/20240126/202401261026.Cc8uBwxf-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261026.Cc8uBwxf-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401261026.Cc8uBwxf-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   kernel/trace/trace.c: In function 'tracing_set_tracer':
>> kernel/trace/trace.c:6645:9: error: 'struct tracer' has no member named 'use_max_tr'
    6645 |    if (t->use_max_tr)
         |         ^~
>> kernel/trace/trace.c:6646:5: error: implicit declaration of function 'tracing_disarm_snapshot_locked'; did you mean 'tracing_disarm_snapshot'? [-Werror=implicit-function-declaration]
    6646 |     tracing_disarm_snapshot_locked(tr);
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |     tracing_disarm_snapshot
   cc1: some warnings being treated as errors


vim +6645 kernel/trace/trace.c

  6641	
  6642		if (t->init) {
  6643			ret = tracer_init(t, tr);
  6644			if (ret) {
> 6645				if (t->use_max_tr)
> 6646					tracing_disarm_snapshot_locked(tr);
  6647				goto out;
  6648			}
  6649		}
  6650	
  6651		tr->current_trace = t;
  6652		tr->current_trace->enabled++;
  6653		trace_branch_enable(tr);
  6654	 out:
  6655		mutex_unlock(&trace_types_lock);
  6656	
  6657		return ret;
  6658	}
  6659	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki