Re: [PATCH v2 1/4] arm64: dts: qcom: Fix hs_phy_irq for QUSB2 targets

[Krishna Kurapati PSSNV]

On 1/25/2024 3:16 AM, Bjorn Andersson wrote:
> On Sun, Jan 21, 2024 at 12:49:01AM +0530, Krishna Kurapati wrote:
> > On several QUSB2 Targets, the hs_phy_irq mentioned is actually
> > qusb2_phy interrupt specific to QUSB2 PHY's. Rename hs_phy_irq
> > to qusb2_phy for such targets.
> >
> > In actuality, the hs_phy_irq is also present in these targets, but
> > kept in for debug purposes in hw test environments. This is not
> > triggered by default and its functionality is mutually exclusive
> > to that of qusb2_phy interrupt.
> >
> > Add missing hs_phy_irq's, pwr_event irq's for QUSB2 PHY targets.
> > Add missing ss_phy_irq on some targets which allows for remote
> > wakeup to work on a Super Speed link.
> >
> > Also modify order of interrupts in accordance to bindings update.
> > Since driver looks up for interrupts by name and not by index, it
> > is safe to modify order of these interrupts in the DT.
> >
> > Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 13 +++++++++++++
> >   arch/arm64/boot/dts/qcom/ipq8074.dtsi | 14 ++++++++++++++
> >   arch/arm64/boot/dts/qcom/msm8953.dtsi |  7 +++++--
> >   arch/arm64/boot/dts/qcom/msm8996.dtsi |  8 ++++++--
> >   arch/arm64/boot/dts/qcom/msm8998.dtsi |  7 +++++--
> >   arch/arm64/boot/dts/qcom/sdm630.dtsi  | 17 +++++++++++++----
> >   arch/arm64/boot/dts/qcom/sm6115.dtsi  |  9 +++++++--
> >   arch/arm64/boot/dts/qcom/sm6125.dtsi  |  9 +++++++--
> >   8 files changed, 70 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > index 5e1277fea725..ea70b57d1871 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> > @@ -418,6 +418,12 @@ usb2: usb@70f8800 {
> >   					  <&gcc GCC_USB1_MOCK_UTMI_CLK>;
> >   			assigned-clock-rates = <133330000>,
> >   					       <24000000>;
> > +
> > +			interrupts-extended = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>,
>
> interrupts-extended takes a reference to a interrupt-controller as well,
> so this doesn't build.
>
> Did you mean "interrupts" here instead? Please update these and build
> test...

Hi Bjorn,

 Thanks for the catch. I was using DTC version 1.4.0.
When I moved to 1.5.0, I did see these warnings. Fixed them up and sent v3.

Thanks,
Krishna,