Re: [PATCH][next] net: ipa: remove the redundant assignment to variable trans_id

[Alex Elder]

On 1/16/24 1:31 PM, Simon Horman wrote:
> On Tue, Jan 16, 2024 at 11:40:25AM +0000, Colin Ian King wrote:
> > The variable trans_id is being modulo'd by channel->tre_count and
> > the value is being re-assigned back to trans_id even though the
> > variable is not used after this operation. The assignment is
> > redundant. Remove the assignment and just replace it with the modulo
> > operator.
> >
> > Cleans up clang scan build warning:
> > warning: Although the value stored to 'trans_id' is used in the
> > enclosing expression, the value is never actually read from
> > 'trans_id' [deadcode.DeadStores]
> >
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Colin, net-next is open now and you are welcome to send v2 of
this patch.
    https://netdev.bots.linux.dev/net-next.html

					-Alex

> ## Form letter - net-next-closed
>
> [adapted from text by Jakub]
>
> Hi Colin,
>
> The merge window for v6.8 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
>
> Please repost when net-next reopens on or after 22nd January.
>
> RFC patches sent for review only are obviously welcome at any time.
>
> See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
> --
> pw-bot: defer