Re: [PATCH v1 3/7] HID: playstation: DS4: Don't fail on FW/HW version request

[Max Staudt]

On 1/25/24 09:43, Roderick Colenbrander wrote:
> On Mon, Jan 15, 2024 at 6:51 AM Max Staudt <max@xxxxxxxxx> wrote:
> >          ret = dualshock4_get_firmware_info(ds4);
> >          if (ret) {
> >                  hid_err(hdev, "Failed to get firmware info from DualShock4\n");
> > -               return ERR_PTR(ret);
> > +               hid_err(hdev, "HW/FW version data in sysfs will be invalid.\n");
> >          }
>
> This looks good. Perhaps could have been a hid_warn then, but err is
> probably fine.

I didn't think about it and kept the hid_err that was already there :)

I agree, and maybe we can take this further: If this code block is not a fatal error anymore, maybe it makes sense to change *both* lines to hid_warn?

If you prefer this, then I'll update the other patches accordingly.


Max