Re: [PATCH v1 0/2] RISC-V: enable rust
From: Miguel Ojeda
Date: Sat Jan 27 2024 - 08:47:05 EST
On Fri, Jan 26, 2024 at 11:01 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> Is that even needed? We already have ARCH_SUPPORTS_CFI_CLANG and AFAIU
> rust supports it if clang does, so a second option is superfluous?
>From a quick look, I don't see it enabled in any RISC-V built-in
target in `rustc` yet.
It may also still be the case that KCFI needs some tweaks for, say,
RISC-V, before the flag actually works, i.e. we couldn't just test the
flag in that case -- Ramon: how likely is it that RISC-V would work if
KCFI works for aarch64 and x86_64?
> I'm reading back what I wrote, and I must have been trying to get out
> the door or something because none of it really makes that much sense.
> Of course an unknown option should be detectable at build time and not
> be a silent breakage. Maybe I should have written the patch for this
> before sending the mail rather than writing the mail based on what was
> in my head.
No worries, it happens. I probably added to the confusion when I
replied with the "testing the unstable flag".
Cheers,
Miguel