Re: [PATCH v2 2/3] clocksource/drivers/imx-sysctr: drop use global variables

[kernel test robot]

Hi Peng,

kernel test robot noticed the following build errors:

[auto build test ERROR on 01af33cc9894b4489fb68fa35c40e9fe85df63dc]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/dt-bindings-timer-nxp-sysctr-timer-support-i-MX95/20240125-191500
base:   01af33cc9894b4489fb68fa35c40e9fe85df63dc
patch link:    https://lore.kernel.org/r/20240125-imx-sysctr-v2-2-7332470cd7ae%40nxp.com
patch subject: [PATCH v2 2/3] clocksource/drivers/imx-sysctr: drop use global variables
config: i386-buildonly-randconfig-001-20240128 (https://download.01.org/0day-ci/archive/20240128/202401280840.br5xJEeO-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240128/202401280840.br5xJEeO-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401280840.br5xJEeO-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/clocksource/timer-imx-sysctr.c:135:9: error: call to undeclared function 'kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     135 |         priv = kzalloc(sizeof(struct sysctr_private), GFP_KERNEL);
         |                ^
   drivers/clocksource/timer-imx-sysctr.c:135:9: note: did you mean 'vzalloc'?
   include/linux/vmalloc.h:141:14: note: 'vzalloc' declared here
     141 | extern void *vzalloc(unsigned long size) __alloc_size(1);
         |              ^
>> drivers/clocksource/timer-imx-sysctr.c:135:7: error: incompatible integer to pointer conversion assigning to 'struct sysctr_private *' from 'int' [-Wint-conversion]
     135 |         priv = kzalloc(sizeof(struct sysctr_private), GFP_KERNEL);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clocksource/timer-imx-sysctr.c:141:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     141 |                 kfree(priv);
         |                 ^
   drivers/clocksource/timer-imx-sysctr.c:141:3: note: did you mean 'vfree'?
   include/linux/vmalloc.h:161:13: note: 'vfree' declared here
     161 | extern void vfree(const void *addr);
         |             ^
   3 errors generated.


vim +/kzalloc +135 drivers/clocksource/timer-imx-sysctr.c

   128	
   129	static int __init sysctr_timer_init(struct device_node *np)
   130	{
   131		struct sysctr_private *priv;
   132		void __iomem *base;
   133		int ret;
   134	
 > 135		priv = kzalloc(sizeof(struct sysctr_private), GFP_KERNEL);
   136		if (!priv)
   137			return -ENOMEM;
   138	
   139		ret = timer_of_init(np, &to_sysctr);
   140		if (ret) {
 > 141			kfree(priv);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki