Re: [PATCH v11 3/5] iommu/vt-d: simplify parameters of qi_submit_sync() ATS invalidation callers
From: kernel test robot
Date: Sun Jan 28 2024 - 00:02:35 EST
Hi Ethan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.8-rc1 next-20240125]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ethan-Zhao/PCI-make-pci_dev_is_disconnected-helper-public-for-other-drivers/20240126-094305
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240126014002.481294-4-haifeng.zhao%40linux.intel.com
patch subject: [PATCH v11 3/5] iommu/vt-d: simplify parameters of qi_submit_sync() ATS invalidation callers
config: x86_64-randconfig-005-20240128 (https://download.01.org/0day-ci/archive/20240128/202401281203.zNQINNbM-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240128/202401281203.zNQINNbM-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401281203.zNQINNbM-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/iommu/intel/svm.c: In function 'intel_flush_svm_all':
>> drivers/iommu/intel/svm.c:229:67: warning: passing argument 2 of 'qi_flush_dev_iotlb_pasid' makes pointer from integer without a cast [-Wint-conversion]
229 | qi_flush_dev_iotlb_pasid(sdev->iommu, sdev->sid, info->pfsid,
| ~~~~^~~~~
| |
| u16 {aka short unsigned int}
In file included from drivers/iommu/intel/svm.c:22:
drivers/iommu/intel/iommu.h:1047:58: note: expected 'struct device_domain_info *' but argument is of type 'u16' {aka 'short unsigned int'}
1047 | struct device_domain_info *info, u64 addr,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/iommu/intel/svm.c:229:25: error: too many arguments to function 'qi_flush_dev_iotlb_pasid'
229 | qi_flush_dev_iotlb_pasid(sdev->iommu, sdev->sid, info->pfsid,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/intel/iommu.h:1046:6: note: declared here
1046 | void qi_flush_dev_iotlb_pasid(struct intel_iommu *iommu,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/intel/svm.c:232:25: error: too many arguments to function 'quirk_extra_dev_tlb_flush'
232 | quirk_extra_dev_tlb_flush(info, 0, 64 - VTD_PAGE_SHIFT,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iommu/intel/iommu.h:1049:6: note: declared here
1049 | void quirk_extra_dev_tlb_flush(struct device_domain_info *info, u32 pasid,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/qi_flush_dev_iotlb_pasid +229 drivers/iommu/intel/svm.c
2f26e0a9c9860d drivers/iommu/intel-svm.c David Woodhouse 2015-09-09 217
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 218 static void intel_flush_svm_all(struct intel_svm *svm)
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 219 {
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 220 struct device_domain_info *info;
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 221 struct intel_svm_dev *sdev;
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 222
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 223 rcu_read_lock();
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 224 list_for_each_entry_rcu(sdev, &svm->devs, list) {
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 225 info = dev_iommu_priv_get(sdev->dev);
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 226
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 227 qi_flush_piotlb(sdev->iommu, sdev->did, svm->pasid, 0, -1UL, 0);
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 228 if (info->ats_enabled) {
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 @229 qi_flush_dev_iotlb_pasid(sdev->iommu, sdev->sid, info->pfsid,
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 230 svm->pasid, sdev->qdep,
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 231 0, 64 - VTD_PAGE_SHIFT);
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 232 quirk_extra_dev_tlb_flush(info, 0, 64 - VTD_PAGE_SHIFT,
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 233 svm->pasid, sdev->qdep);
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 234 }
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 235 }
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 236 rcu_read_unlock();
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 237 }
e7ad6c2a4b1aa7 drivers/iommu/intel/svm.c Lu Baolu 2023-11-22 238
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki