Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline

From: Jiri Olsa
Date: Sun Jan 28 2024 - 04:05:09 EST


On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <dongmenglong.8@xxxxxxxxxxxxx>

Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka


> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
> int progs_cnt[BPF_TRAMP_MAX];
> /* Executable image of trampoline */
> struct bpf_tramp_image *cur_image;
> - struct module *mod;
> };
>
> struct bpf_attach_target_info {
> --
> 2.39.2
>