Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

From: Andy Shevchenko
Date: Sun Jan 28 2024 - 09:38:19 EST

Next message: Russell King (Oracle): "Re: [PATCH net-next] net: sfp: add quirk for OEM DFP-34X-2C2 GPON ONU SFP DFP-34X-2C2 is a GPON spf module working at both1000baseX and 2500baseX. Setting the module to LAN_SDS_MODE=6 the module is working at 2500baseX with auto negotiation see at https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ Unfortunatly the module's PHY is accessible at 1000baseX only. ethtool returning: Supported ports: [Fibre ] Supported link modes: 1000baseX/Full"
Previous message: Markus Elfring: "[PATCH] misc: fastrpc: Use memdup_user() rather than duplicating its implementation"
In reply to: Daniel Thompson: "Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Jan 24, 2024 at 05:19:53PM +0000, Daniel Thompson wrote:
> On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote:

..

> > +typedef int (*hx8357_init)(struct lcd_device *);

> > + hx8357_init init;
>
> As somewhere else in this thread, I'd find this a lot more readable
> as:
> hx8357_init_fn init_fn;

I agree with you, dunno why I haven't added _fn in the first place...

--
With Best Regards,
Andy Shevchenko