RE: [EXTERNAL] Re: [PATCH v2 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

[Ding, Shenghao]

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Friday, January 26, 2024 9:50 PM
> To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Cc: Ding, Shenghao <shenghao-ding@xxxxxx>; conor+dt@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; Lu, Kevin <kevin-
> lu@xxxxxx>; Xu, Baojun <baojun.xu@xxxxxx>; devicetree@xxxxxxxxxxxxxxx; P
> O, Vijeth <v-po@xxxxxx>; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre-
> louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; Chawla, Mohit
> <mohit.chawla@xxxxxx>; linux-sound@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; Huang,
> Jonathan <jkhuang3@xxxxxx>; tiwai@xxxxxxx; Djuandi, Peter
> <pdjuandi@xxxxxx>; McPherson, Jeff <j-mcpherson@xxxxxx>; Navada
> Kanyana, Mukund <navada@xxxxxx>
> Subject: [EXTERNAL] Re: [PATCH v2 4/4] ASoc: dt-bindings: PCM6240: Add
> initial DT binding
> 
> On Fri, Jan 26, 2024 at 09:27:47AM +0100, Krzysztof Kozlowski wrote:
> > On 26/01/2024 04:58, Shenghao Ding wrote:
> 
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            enum:
> > > +              - ti,pcm1690
> > > +    then:
> > > +      properties:
> > > +        reg:
> > > +          items:
> > > +            minimum: 0x4c
> > > +            maximum: 0x4f
> 
> > Nothing improved.
> 
> Shenghao explained what what this is doing - I'm not sure what the actual
> problem is here?  It's an actual restriction on the values that are valid.

Hi, Krzysztof. May I have the privilege to petition on behalf of my customers? They 
want to keep these if branches and the i2c address in yaml file. As you know, most 
of my customers used to make mistakes and confuse with the i2c address. Listing 
them here can help them to get the information easily.