Re: [PATCH 5/9] arm64: dts: exynos: gs101: define USI12 with I2C configuration

[André Draszik]

On Fri, 2024-01-26 at 20:55 -0600, Sam Protsenko wrote:
> On Fri, Jan 26, 2024 at 6:19 PM André Draszik <andre.draszik@xxxxxxxxxx> wrote:
> > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > @@ -450,6 +450,36 @@ pinctrl_peric1: pinctrl@10c40000 {
> >                         interrupts = <GIC_SPI 644 IRQ_TYPE_LEVEL_HIGH 0>;
> >                 };
> > 
> > +               usi12: usi@10d500c0 {
> > +                       compatible = "google,gs101-usi",
> > +                                    "samsung,exynos850-usi";
> 
> It doesn't fit on one line?

No, it's 81 characters. While I know it's not a hard rule in this case,
there are other cases in this file where the line was split in the same
way, so I followed that.

> > +                               pinctrl-names = "default";
> > +                               pinctrl-0 = <&hsi2c12_bus>;
> 
> I remember Krzysztof asked me to put pinctrl-0 first in my recent
> patches. Not sure how important it is, just saying. Other than that,

Makes sense, this came from a copy/paste and I have fixed it.

Cheers,
Andre'