Re: [PATCH net-next v3 6/7] net: dsa: mt7530: do not set priv->p5_interface on mt7530_setup_port5()

From: Arınç ÜNAL
Date: Mon Jan 29 2024 - 11:22:56 EST


On 29.01.2024 15:52, Vladimir Oltean wrote:
On Mon, Jan 22, 2024 at 08:35:57AM +0300, Arınç ÜNAL via B4 Relay wrote:
From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

Running mt7530_setup_port5() from mt7530_setup() used to handle all cases
of configuring port 5, including phylink.

Setting priv->p5_interface under mt7530_setup_port5() makes sure that
mt7530_setup_port5() from mt753x_phylink_mac_config() won't run.

The commit ("net: dsa: mt7530: improve code path for setting up port 5")
makes so that mt7530_setup_port5() from mt7530_setup() runs only on
non-phylink cases.

Get rid of unnecessarily setting priv->p5_interface under
mt7530_setup_port5() as port 5 phylink configuration will be done by
running mt7530_setup_port5() from mt753x_phylink_mac_config() now.

Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>

I hope this moves the patch set out of the 'deferred' state.

---
pw-bot: under-review

I still see deferred. I guess I'll have to submit this again. :/

Arınç