Re: [PATCH] thermal/sysfs: Always enable hysteresis write support

[Daniel Lezcano]

Hi Rafael,

On 29/01/2024 18:07, Rafael J. Wysocki wrote:

[ ... ]

> > Index: linux-pm/drivers/thermal/thermal_sysfs.c
> > ===================================================================
> > --- linux-pm.orig/drivers/thermal/thermal_sysfs.c
> > +++ linux-pm/drivers/thermal/thermal_sysfs.c
> > @@ -474,7 +474,8 @@ static int create_trip_attrs(struct ther
> >                       tz->trip_hyst_attrs[indx].name;
> >           tz->trip_hyst_attrs[indx].attr.attr.mode = S_IRUGO;
> >           tz->trip_hyst_attrs[indx].attr.show = trip_point_hyst_show;
> > -        if (tz->ops->set_trip_hyst) {
> > +        if (IS_ENABLED(CONFIG_THERMAL_WRITABLE_TRIPS) &&
> > +            mask & (1 << indx)) {
> >               tz->trip_hyst_attrs[indx].attr.attr.mode |= S_IWUSR;
> >               tz->trip_hyst_attrs[indx].attr.store =
> >                       trip_point_hyst_store;
>
> So it looks like I need to submit this, even though I'm not sure if
> anyone cares.
>
> In any case, I care about consistency.

Yeah, sorry for the delay. I'll have a look at it tomorrow

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog