Re: [PATCH v12 1/5] PCI: make pci_dev_is_disconnected() helper public for other drivers

[Ethan Zhao]

On 1/29/2024 4:50 PM, Tian, Kevin wrote:
> > From: Ethan Zhao <haifeng.zhao@xxxxxxxxxxxxxxx>
> > Sent: Monday, January 29, 2024 11:49 AM
> >
> > Make pci_dev_is_disconnected() public so that it can be called from
> > Intel VT-d driver to quickly fix/workaround the surprise removal
> > unplug hang issue for those ATS capable devices on PCIe switch downstream
> > hotplug capable ports.
> >
> > Beside pci_device_is_present() function, this one has no config space
> s/Beside/Unlike/
>
> > space access, so is light enough to optimize the normal pure surprise
> > removal and safe removal flow.
> somehow this paragraph belongs to the patch using it. The 1st paragraph
> is sufficient for the reason of exposure.

pci_device_is_present() is aleardy exported symbol, why not just use it ?

Also try to make it clear, the difference and justification.


Thanks,
Ethan