Re: [PATCH v12 4/5] iommu/vt-d: pass pdev parameter for qi_check_fault() and refactor callers

[Ethan Zhao]

On 1/29/2024 4:58 PM, Tian, Kevin wrote:
> > From: Ethan Zhao <haifeng.zhao@xxxxxxxxxxxxxxx>
> > Sent: Monday, January 29, 2024 11:49 AM
> >
> > to check state of ATS capable pci device in qi_check_fault() for surprise
> > removal case, we need to pass the target pci device of ATS invalidation
> > request to qi_check_fault(). if pdev is valid, means current request is for
> > ATS invalidation, vice vesa.
> >
> > no function change.
> qi_submit_sync() is used for all kinds of iotlb/cache/devtlb invalidations.
> it's a bit weird to see a device pointer (even being NULL) in places where
> a device doesn't even matter.
>
> having a new qi_submit_sync_devtlb() wrapper sounds cleaner to me,
> with an internal __qi_submit_sync() helper to accept a device pointer.
>
> qi_submit_sync() calls __qi_submit_sync() with a null device pointer then
> non-devtlb paths are intact.

Make sense !

That way, could keep about 10 qi_submit_sync() calling intact, while

only 2-3 qi_submit_sync_devtlb() wrapper calling needed.

Thanks,

Ethan