RE: [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>
> Sent: Tuesday, January 30, 2024 9:26 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>
> Subject: Fwd: [PATCH iwl v2] i40e: print correct hw max rss count
> in kernel ring buffer
> 
> FWD to Alex
> 
> 
> -------- Forwarded Message --------
> Subject: [PATCH iwl v2] i40e: print correct hw max rss count in
> kernel ring buffer
> Date: Sat, 20 Jan 2024 12:58:06 +0530
> From: Suresh Kumar <suresh2514@xxxxxxxxx>
> To: jesse.brandeburg@xxxxxxxxx, anthony.l.nguyen@xxxxxxxxx,
> davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx,
> pabeni@xxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx,
> netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> CC: Suresh Kumar <suresh2514@xxxxxxxxx>
> 
> pf->rss_size_max is hardcoded and always prints max rss count as
> 64.
> 
> Eg:
>    kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS
> count:  104/64
> 
> whereas  ethtool reports the correct value from "vsi-
> >num_queue_pairs"
> 
> Channel parameters for eno33:
> Pre-set maximums:
> RX:     n/a
> TX:     n/a
> Other:      1
> Combined:   104
> Current hardware settings:
> RX:     n/a
> TX:     n/a
> Other:      1
> Combined:   104  <-------
> 
> and is misleading.
> 
> Change it to vsi->num_queue_pairs

Please reject this patch, it breaks driver logging.
The massage clearly states that it dumps max rss queues number that f/w supports.

Thank you
 
> Signed-off-by: Suresh Kumar <suresh2514@xxxxxxxxx>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index d5519af34657..f5c1ec190f7e 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf
> *pf, int queue_count)
>   		i40e_pf_config_rss(pf);
>   	}
>   	dev_info(&pf->pdev->dev, "User requested queue count/HW max
> RSS
> count:  %d/%d\n",
> -		 vsi->req_queue_pairs, pf->rss_size_max);
> +		 vsi->req_queue_pairs, vsi->num_queue_pairs);
>   	return pf->alloc_rss_size;
>   }
>   -- 2.43.0
>