RE: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS Zenbook UX3402VA

[Stefan Binding]

Hi,

> -----Original Message-----
> From: Takashi Iwai <tiwai@xxxxxxx>
> Sent: Tuesday, January 30, 2024 11:05 AM
> To: Kenzo Gomez <kenzo.sgomez@xxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx; david.rhodes@xxxxxxxxxx;
> james.schulman@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> sound@xxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxx;
> perex@xxxxxxxx; rf@xxxxxxxxxxxxxxxxxxxxx;
> sbinding@xxxxxxxxxxxxxxxxxxxxx; tiwai@xxxxxxxx
> Subject: Re: [PATCH v3] ALSA: hda: cs35l41: Support additional ASUS
> Zenbook UX3402VA
> 
> On Sat, 27 Jan 2024 17:46:21 +0100,
> Kenzo Gomez wrote:
> >
> > Add new model entry into configuration table.
> >
> > Signed-off-by: Kenzo Gomez <kenzo.sgomez@xxxxxxxxx>
> 
> Cirrus people, could you take a look?
> I'm inclined to take as is, unless you have any objections.

Looks good to me.

Thanks,
Stefan

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/cs35l41_hda_property.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> > index 35277ce890a4..59504852adc6 100644
> > --- a/sound/pci/hda/cs35l41_hda_property.c
> > +++ b/sound/pci/hda/cs35l41_hda_property.c
> > @@ -76,6 +76,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
> >  	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 0, 1, -1, 1000, 4500, 24 },
> >  	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 1000, 4500, 24 },
> >  	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, -1, 0, 1000, 4500, 24 },
> > +	{ "104316A3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> >  	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> >  	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 1, 2, 0, 0, 0, 0 },
> >  	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0,
> 0 }, 0, 1, -1, 1000, 4500, 24 },
> > @@ -410,6 +411,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
> >  	{ "CSC3551", "10431533", generic_dsd_config },
> >  	{ "CSC3551", "10431573", generic_dsd_config },
> >  	{ "CSC3551", "10431663", generic_dsd_config },
> > +	{ "CSC3551", "104316A3", generic_dsd_config },
> >  	{ "CSC3551", "104316D3", generic_dsd_config },
> >  	{ "CSC3551", "104316F3", generic_dsd_config },
> >  	{ "CSC3551", "104317F3", generic_dsd_config },
> > --
> > 2.43.0
> >