Re: [PATCH printk v3 05/14] printk: ringbuffer: Clarify special lpos values

[Petr Mladek]

On Thu 2023-12-14 22:47:52, John Ogness wrote:
> For empty line records, no data blocks are created. Instead,
> these valid records are identified by special logical position
> values (in fields of @prb_desc.text_blk_lpos).
> 
> Currently the macro NO_LPOS is used for empty line records.
> This name is confusing because it does not imply _why_ there is
> no data block.
> 
> Rename NO_LPOS to EMPTY_LINE_LPOS so that it is clear why there
> is no data block.
> 
> Also add comments explaining the use of EMPTY_LINE_LPOS as well
> as clarification to the values used to represent data-less
> blocks.
> 
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr

PS: Just for record. I had to make a pause in the review
    because I have been on a sick leave last week and half.