Re: [PATCHv5 1/1] block: introduce content activity based ioprio

[Damien Le Moal]

On 1/30/24 22:28, Zhaoyang Huang wrote:
>> That information does not belong to the ioprio. And which scheduler acts on a
>> number of pages anyway ? The scheduler sees requests and BIOs. It can determine
>> the number of pages they have if that is an information it needs to make
>> scheduling decisison. Using ioprio to pass that information down is a dirty hack.
> No. IO scheduler acts on IOPRIO_CLASS which is transferred from the
> page's activity by the current method. I will implement another
> version of iterating pages before submit_bio and feed back to the list

Then why are you modifying the ioprio user API to add the 7 bits of activity ?
If the scheduler only needs the priority class, then only set that and do not
touch the user facing API.

-- 
Damien Le Moal
Western Digital Research