Re: [PATCH AUTOSEL 6.7 15/18] platform/x86: wmi: Remove ACPI handlers after WMI devices

[Sasha Levin]

On Tue, Jan 16, 2024 at 12:53:46PM +0100, Armin Wolf wrote:
> Am 16.01.24 um 01:12 schrieb Sasha Levin:
>
> > From: Armin Wolf <W_Armin@xxxxxx>
> >
> > [ Upstream commit 22574e17626391ad969af9a13aaa58a1b37ad384 ]
> >
> > When removing the ACPI notify/address space handlers, the WMI devices
> > are still active and might still depend on ACPI EC access or
> > WMI events.
> > Fix this by removing the ACPI handlers after all WMI devices
> > associated with an ACPI device have been removed.
>
> Hello,
>
> i would advise against including this patch in the next stable kernels.
>
> The WMI ACPI notify handler is still using list_for_each_entry() which is
> not safe when the WMI devices are removed before the ACPI notify handler.
>
> This issue existed inside the WMI code for a long time, but this patch might
> trigger it. Since no users reported any issues regarding ACPI errors during
> WMI removal, i would drop this patch.

Ack, I'll drop it.

--
Thanks,
Sasha