Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY
From: Adam Ford
Date: Tue Jan 30 2024 - 21:45:21 EST
On Tue, Jan 30, 2024 at 11:00 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> Hi Adam,
>
> On 06-01-24, 16:19, Adam Ford wrote:
> > From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> >
> > This adds the driver for the Samsung HDMI PHY found on the
> > i.MX8MP SoC.
> >
> > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> > ---
> > V2: Fixed some whitespace found from checkpatch
> > Change error handling when enabling apbclk to use dev_err_probe
> > Rebase on Linux-Next
> >
> > I (Adam) tried to help move this along, so I took Lucas' patch and
> > attempted to apply fixes based on feedback. I don't have
> > all the history, so apologies for that.
> >
> > diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig
> > index 853958fb2c06..5c2b73042dfc 100644
> > --- a/drivers/phy/freescale/Kconfig
> > +++ b/drivers/phy/freescale/Kconfig
> > @@ -35,6 +35,12 @@ config PHY_FSL_IMX8M_PCIE
> > Enable this to add support for the PCIE PHY as found on
> > i.MX8M family of SOCs.
> >
> > +config PHY_FSL_SAMSUNG_HDMI_PHY
> > + tristate "Samsung HDMI PHY support"
> > + depends on OF && HAS_IOMEM
> > + help
> > + Enable this to add support for the Samsung HDMI PHY in i.MX8MP.
> > +
> > endif
> >
> > config PHY_FSL_LYNX_28G
> > diff --git a/drivers/phy/freescale/Makefile b/drivers/phy/freescale/Makefile
> > index cedb328bc4d2..dbcafdcc8751 100644
> > --- a/drivers/phy/freescale/Makefile
> > +++ b/drivers/phy/freescale/Makefile
> > @@ -3,4 +3,5 @@ obj-$(CONFIG_PHY_FSL_IMX8MQ_USB) += phy-fsl-imx8mq-usb.o
> > obj-$(CONFIG_PHY_MIXEL_LVDS_PHY) += phy-fsl-imx8qm-lvds-phy.o
> > obj-$(CONFIG_PHY_MIXEL_MIPI_DPHY) += phy-fsl-imx8-mipi-dphy.o
> > obj-$(CONFIG_PHY_FSL_IMX8M_PCIE) += phy-fsl-imx8m-pcie.o
> > +obj-$(CONFIG_PHY_FSL_SAMSUNG_HDMI_PHY) += phy-fsl-samsung-hdmi.o
> > obj-$(CONFIG_PHY_FSL_LYNX_28G) += phy-fsl-lynx-28g.o
> > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c
> > new file mode 100644
> > index 000000000000..54e93ea898f7
> > --- /dev/null
> > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c
> > @@ -0,0 +1,1078 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2020 NXP
> > + * Copyright 2022 Pengutronix, Lucas Stach <kernel@xxxxxxxxxxxxxx>
> > + */
> > +
> > +#include <linux/clk-provider.h>
> > +#include <linux/clk.h>
> > +#include <linux/delay.h>
> > +#include <linux/io.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> > +
> > +#define HDMI_TX_CONTROL0 0x200
> > +#define HDMI_TX_CONTROL_PHY_PWRDWN BIT(3)
> > +
> > +#define PHY_REG_33 0x84
> > +#define REG33_MODE_SET_DONE BIT(7)
> > +#define REG33_FIX_DA BIT(1)
> > +
> > +#define PHY_REG_34 0x88
> > +#define REG34_PHY_READY BIT(7)
> > +#define REG34_PLL_LOCK BIT(6)
> > +#define REG34_PHY_CLK_READY BIT(5)
> > +
> > +
> > +#define PHY_PLL_REGS_NUM 48
> > +
> > +struct phy_config {
> > + u32 clk_rate;
> > + u8 regs[PHY_PLL_REGS_NUM];
> > +};
> > +
> > +const struct phy_config phy_pll_cfg[] = {
> > + { 22250000, {
> > + 0x00, 0xD1, 0x4B, 0xF1, 0x89, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x15, 0x25, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
>
> can we please have lower case hex values
I'll update that for the next revision.
>
> > + },
> > + }, {
> > + 23750000, {
> > + 0x00, 0xD1, 0x50, 0xF1, 0x86, 0x85, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x03, 0x25, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 24000000, {
> > + 0x00, 0xD1, 0x50, 0xF0, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x01, 0x25, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 24024000, {
> > + 0x00, 0xD1, 0x50, 0xF1, 0x99, 0x02, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x00, 0x25, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 25175000, {
> > + 0x00, 0xD1, 0x54, 0xFC, 0xCC, 0x91, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xF5, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 25200000, {
> > + 0x00, 0xD1, 0x54, 0xF0, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xF4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 26750000, {
> > + 0x00, 0xD1, 0x5A, 0xF2, 0x89, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xE6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 27000000, {
> > + 0x00, 0xD1, 0x5A, 0xF0, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 27027000, {
> > + 0x00, 0xD1, 0x5A, 0xF2, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 29500000, {
> > + 0x00, 0xD1, 0x62, 0xF4, 0x95, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xD1, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 30750000, {
> > + 0x00, 0xD1, 0x66, 0xF4, 0x82, 0x01, 0x88, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xC8, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 30888000, {
> > + 0x00, 0xD1, 0x66, 0xF4, 0x99, 0x18, 0x88, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xC7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 33750000, {
> > + 0x00, 0xD1, 0x70, 0xF4, 0x82, 0x01, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xB7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8F, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 35000000, {
> > + 0x00, 0xD1, 0x58, 0xB8, 0x8B, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xB0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8B, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 36000000, {
> > + 0x00, 0xD1, 0x5A, 0xB0, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8B, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 36036000, {
> > + 0x00, 0xD1, 0x5A, 0xB2, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8B, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 40000000, {
> > + 0x00, 0xD1, 0x64, 0xB0, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x9A, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x8B, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 43200000, {
> > + 0x00, 0xD1, 0x5A, 0x90, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x8F, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x89, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 43243200, {
> > + 0x00, 0xD1, 0x5A, 0x92, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x8F, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x89, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 44500000, {
> > + 0x00, 0xD1, 0x5C, 0x92, 0x98, 0x11, 0x84, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x8B, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x89, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 47000000, {
> > + 0x00, 0xD1, 0x62, 0x94, 0x95, 0x82, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x83, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x89, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 47500000, {
> > + 0x00, 0xD1, 0x63, 0x96, 0xA1, 0x82, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x00, 0x82, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x89, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 50349650, {
> > + 0x00, 0xD1, 0x54, 0x7C, 0xC3, 0x8F, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xF5, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 50400000, {
> > + 0x00, 0xD1, 0x54, 0x70, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xF4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 53250000, {
> > + 0x00, 0xD1, 0x58, 0x72, 0x84, 0x03, 0x82, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xE7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 53500000, {
> > + 0x00, 0xD1, 0x5A, 0x72, 0x89, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xE6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 54000000, {
> > + 0x00, 0xD1, 0x5A, 0x70, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 54054000, {
> > + 0x00, 0xD1, 0x5A, 0x72, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 59000000, {
> > + 0x00, 0xD1, 0x62, 0x74, 0x95, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xD1, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 59340659, {
> > + 0x00, 0xD1, 0x62, 0x74, 0xDB, 0x52, 0x88, 0x47,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xD0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 59400000, {
> > + 0x00, 0xD1, 0x63, 0x70, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xCF, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 61500000, {
> > + 0x00, 0xD1, 0x66, 0x74, 0x82, 0x01, 0x88, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xC8, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 63500000, {
> > + 0x00, 0xD1, 0x69, 0x74, 0x89, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xC2, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x87, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 67500000, {
> > + 0x00, 0xD1, 0x54, 0x52, 0x87, 0x03, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xB7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 70000000, {
> > + 0x00, 0xD1, 0x58, 0x58, 0x8B, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xB0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 72000000, {
> > + 0x00, 0xD1, 0x5A, 0x50, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 72072000, {
> > + 0x00, 0xD1, 0x5A, 0x52, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 74176000, {
> > + 0x00, 0xD1, 0x5D, 0x58, 0xDB, 0xA2, 0x88, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xA6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 74250000, {
> > + 0x00, 0xD1, 0x5C, 0x52, 0x90, 0x0D, 0x84, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0xA6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 78500000, {
> > + 0x00, 0xD1, 0x62, 0x54, 0x87, 0x01, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x9D, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 80000000, {
> > + 0x00, 0xD1, 0x64, 0x50, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x9A, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 82000000, {
> > + 0x00, 0xD1, 0x66, 0x54, 0x82, 0x01, 0x88, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x96, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 82500000, {
> > + 0x00, 0xD1, 0x67, 0x54, 0x88, 0x01, 0x90, 0x49,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x95, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 89000000, {
> > + 0x00, 0xD1, 0x70, 0x54, 0x84, 0x83, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x8B, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 90000000, {
> > + 0x00, 0xD1, 0x70, 0x54, 0x82, 0x01, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x89, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x85, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 94000000, {
> > + 0x00, 0xD1, 0x4E, 0x32, 0xA7, 0x10, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x83, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 95000000, {
> > + 0x00, 0xD1, 0x50, 0x31, 0x86, 0x85, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x82, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 98901099, {
> > + 0x00, 0xD1, 0x52, 0x3A, 0xDB, 0x4C, 0x88, 0x47,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x7D, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 99000000, {
> > + 0x00, 0xD1, 0x52, 0x32, 0x82, 0x01, 0x88, 0x47,
> > + 0x4F, 0x30, 0x33, 0x65, 0x10, 0x7D, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 100699300, {
> > + 0x00, 0xD1, 0x54, 0x3C, 0xC3, 0x8F, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xF5, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 100800000, {
> > + 0x00, 0xD1, 0x54, 0x30, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xF4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 102500000, {
> > + 0x00, 0xD1, 0x55, 0x32, 0x8C, 0x05, 0x90, 0x4B,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xF0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 104750000, {
> > + 0x00, 0xD1, 0x57, 0x32, 0x98, 0x07, 0x90, 0x49,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xEB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 106500000, {
> > + 0x00, 0xD1, 0x58, 0x32, 0x84, 0x03, 0x82, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xE7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 107000000, {
> > + 0x00, 0xD1, 0x5A, 0x32, 0x89, 0x88, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xE6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 108000000, {
> > + 0x00, 0xD1, 0x5A, 0x30, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 108108000, {
> > + 0x00, 0xD1, 0x5A, 0x32, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 118000000, {
> > + 0x00, 0xD1, 0x62, 0x34, 0x95, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xD1, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 118800000, {
> > + 0x00, 0xD1, 0x63, 0x30, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xCF, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 123000000, {
> > + 0x00, 0xD1, 0x66, 0x34, 0x82, 0x01, 0x88, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xC8, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 127000000, {
> > + 0x00, 0xD1, 0x69, 0x34, 0x89, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xC2, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 135000000, {
> > + 0x00, 0xD1, 0x70, 0x34, 0x82, 0x01, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xB7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 135580000, {
> > + 0x00, 0xD1, 0x71, 0x39, 0xE9, 0x82, 0x9C, 0x5B,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xB6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 137520000, {
> > + 0x00, 0xD1, 0x72, 0x38, 0x99, 0x10, 0x85, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xB3, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 138750000, {
> > + 0x00, 0xD1, 0x73, 0x35, 0x88, 0x05, 0x90, 0x4D,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xB2, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 140000000, {
> > + 0x00, 0xD1, 0x75, 0x36, 0xA7, 0x90, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xB0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 144000000, {
> > + 0x00, 0xD1, 0x78, 0x30, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 148352000, {
> > + 0x00, 0xD1, 0x7B, 0x35, 0xDB, 0x39, 0x90, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xA6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 148500000, {
> > + 0x00, 0xD1, 0x7B, 0x35, 0x84, 0x03, 0x90, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xA6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x83, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 154000000, {
> > + 0x00, 0xD1, 0x40, 0x18, 0x83, 0x01, 0x00, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0xA0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 157000000, {
> > + 0x00, 0xD1, 0x41, 0x11, 0xA7, 0x14, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x9D, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 160000000, {
> > + 0x00, 0xD1, 0x42, 0x12, 0xA1, 0x20, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x9A, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 162000000, {
> > + 0x00, 0xD1, 0x43, 0x18, 0x8B, 0x08, 0x96, 0x55,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x98, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 164000000, {
> > + 0x00, 0xD1, 0x45, 0x11, 0x83, 0x82, 0x90, 0x4B,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x96, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 165000000, {
> > + 0x00, 0xD1, 0x45, 0x11, 0x84, 0x81, 0x90, 0x4B,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x95, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 180000000, {
> > + 0x00, 0xD1, 0x4B, 0x10, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x89, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 185625000, {
> > + 0x00, 0xD1, 0x4E, 0x12, 0x9A, 0x95, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x85, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 188000000, {
> > + 0x00, 0xD1, 0x4E, 0x12, 0xA7, 0x10, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x83, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 198000000, {
> > + 0x00, 0xD1, 0x52, 0x12, 0x82, 0x01, 0x88, 0x47,
> > + 0x4F, 0x30, 0x33, 0x65, 0x20, 0x7D, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 205000000, {
> > + 0x00, 0xD1, 0x55, 0x12, 0x8C, 0x05, 0x90, 0x4B,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xF0, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 209500000, {
> > + 0x00, 0xD1, 0x57, 0x12, 0x98, 0x07, 0x90, 0x49,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xEB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 213000000, {
> > + 0x00, 0xD1, 0x58, 0x12, 0x84, 0x03, 0x82, 0x41,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xE7, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 216000000, {
> > + 0x00, 0xD1, 0x5A, 0x10, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 216216000, {
> > + 0x00, 0xD1, 0x5A, 0x12, 0xFD, 0x0C, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xE4, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 237600000, {
> > + 0x00, 0xD1, 0x63, 0x10, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xCF, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 254000000, {
> > + 0x00, 0xD1, 0x69, 0x14, 0x89, 0x08, 0x80, 0x40,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xC2, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 277500000, {
> > + 0x00, 0xD1, 0x73, 0x15, 0x88, 0x05, 0x90, 0x4D,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xB2, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 288000000, {
> > + 0x00, 0xD1, 0x78, 0x10, 0x00, 0x00, 0x80, 0x00,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xAB, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + }, {
> > + 297000000, {
> > + 0x00, 0xD1, 0x7B, 0x15, 0x84, 0x03, 0x90, 0x45,
> > + 0x4F, 0x30, 0x33, 0x65, 0x30, 0xA6, 0x24, 0x80,
> > + 0x6C, 0xF2, 0x67, 0x00, 0x10, 0x81, 0x30, 0x32,
> > + 0x60, 0x8F, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00,
> > + 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0xE0, 0x83, 0x0F, 0x3E, 0xF8, 0x00, 0x00,
> > + },
> > + },
> > +};
>
> what is the source of these values. do we know what they represent ?
I didn't write the original driver, but looking at the imx8MP Tech Ref
Manual, there are 47 PHY registers named PHY_REG1 through PHY_REG47,
and each are 8-bits wide. This is basically a lookup table which sets
the PHY registers based on the desired clock. The manual documents
what each register is responsible for doing, but they didn't give them
interesting names.
adam
>
> > +
> > +struct fsl_samsung_hdmi_phy {
> > + struct device *dev;
> > + void __iomem *regs;
> > + struct clk *apbclk;
> > + struct clk *refclk;
> > +
> > + /* clk provider */
> > + struct clk_hw hw;
> > + const struct phy_config *cur_cfg;
> > +};
> > +
> > +static inline struct fsl_samsung_hdmi_phy *
> > +to_fsl_samsung_hdmi_phy(struct clk_hw *hw)
> > +{
> > + return container_of(hw, struct fsl_samsung_hdmi_phy, hw);
> > +}
> > +
> > +static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy,
> > + const struct phy_config *cfg)
> > +{
> > + int i, ret;
> > + u8 val;
> > +
> > + /* HDMI PHY init */
> > + writeb(REG33_FIX_DA, phy->regs + PHY_REG_33);
> > +
> > + for (i = 0; i < PHY_PLL_REGS_NUM; i++)
> > + writeb(cfg->regs[i], phy->regs + i * 4);
> > +
> > + writeb(REG33_FIX_DA | REG33_MODE_SET_DONE, phy->regs + PHY_REG_33);
> > +
> > + ret = readb_poll_timeout(phy->regs + PHY_REG_34, val,
> > + val & REG34_PLL_LOCK,
> > + 50, 20000);
> > + if (ret)
> > + dev_err(phy->dev, "PLL failed to lock\n");
> > +
> > + return ret;
> > +}
> > +
> > +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw,
> > + unsigned long parent_rate)
> > +{
> > + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw);
> > +
> > + if (!phy->cur_cfg)
> > + return 74250000;
> > +
> > + return phy->cur_cfg->clk_rate;
> > +}
> > +
> > +static long phy_clk_round_rate(struct clk_hw *hw,
> > + unsigned long rate, unsigned long *parent_rate)
> > +{
> > + int i;
> > +
> > + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--)
> > + if (phy_pll_cfg[i].clk_rate <= rate)
> > + return phy_pll_cfg[i].clk_rate;
> > +
> > + return -EINVAL;
> > +}
> > +
> > +static int phy_clk_set_rate(struct clk_hw *hw,
> > + unsigned long rate, unsigned long parent_rate)
> > +{
> > + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw);
> > + int i;
> > +
> > + for (i = ARRAY_SIZE(phy_pll_cfg) - 1; i >= 0; i--)
> > + if (phy_pll_cfg[i].clk_rate <= rate)
> > + break;
> > +
> > + if (i < 0)
> > + return -EINVAL;
> > +
> > + phy->cur_cfg = &phy_pll_cfg[i];
> > +
> > + return fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg);
> > +}
> > +
> > +static const struct clk_ops phy_clk_ops = {
> > + .recalc_rate = phy_clk_recalc_rate,
> > + .round_rate = phy_clk_round_rate,
> > + .set_rate = phy_clk_set_rate,
> > +};
> > +
> > +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy)
> > +{
> > + struct device *dev = phy->dev;
> > + struct device_node *np = dev->of_node;
> > + struct clk_init_data init;
> > + const char *parent_name;
> > + struct clk *phyclk;
> > + int ret;
> > +
> > + parent_name = __clk_get_name(phy->refclk);
> > +
> > + init.parent_names = &parent_name;
> > + init.num_parents = 1;
> > + init.flags = 0;
> > + init.name = "hdmi_pclk";
> > + init.ops = &phy_clk_ops;
> > +
> > + phy->hw.init = &init;
> > +
> > + phyclk = devm_clk_register(dev, &phy->hw);
> > + if (IS_ERR(phyclk))
> > + return dev_err_probe(dev, PTR_ERR(phyclk),
> > + "failed to register clock\n");
> > +
> > + ret = of_clk_add_provider(np, of_clk_src_simple_get, phyclk);
> > + if (ret)
> > + return dev_err_probe(dev, ret,
> > + "failed to register clock provider\n");
> > +
> > + return 0;
> > +}
> > +
> > +static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev)
> > +{
> > + struct fsl_samsung_hdmi_phy *phy;
> > + int ret;
> > +
> > + phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
> > + if (!phy)
> > + return -ENOMEM;
> > +
> > + platform_set_drvdata(pdev, phy);
> > + phy->dev = &pdev->dev;
> > +
> > + phy->regs = devm_platform_ioremap_resource(pdev, 0);
> > + if (IS_ERR(phy->regs))
> > + return PTR_ERR(phy->regs);
> > +
> > + phy->apbclk = devm_clk_get(phy->dev, "apb");
> > + if (IS_ERR(phy->apbclk))
> > + return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk),
> > + "failed to get apb clk\n");
> > +
> > + phy->refclk = devm_clk_get(phy->dev, "ref");
> > + if (IS_ERR(phy->refclk))
> > + return dev_err_probe(phy->dev, PTR_ERR(phy->refclk),
> > + "failed to get ref clk\n");
> > +
> > + ret = clk_prepare_enable(phy->apbclk);
> > + if (ret) {
> > + return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk),
> > + "failed to enable apbclk\n");
> > + }
> > +
> > + pm_runtime_get_noresume(phy->dev);
> > + pm_runtime_set_active(phy->dev);
> > + pm_runtime_enable(phy->dev);
> > +
> > + ret = phy_clk_register(phy);
> > + if (ret) {
> > + dev_err(&pdev->dev, "register clk failed\n");
> > + goto register_clk_failed;
> > + }
> > +
> > + pm_runtime_put(phy->dev);
> > +
> > + return 0;
> > +
> > +register_clk_failed:
> > + clk_disable_unprepare(phy->apbclk);
> > +
> > + return ret;
> > +}
> > +
> > +static int fsl_samsung_hdmi_phy_remove(struct platform_device *pdev)
> > +{
> > + of_clk_del_provider(pdev->dev.of_node);
> > +
> > + return 0;
> > +}
> > +
> > +#ifdef CONFIG_PM
> > +static int fsl_samsung_hdmi_phy_suspend(struct device *dev)
> > +{
> > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev);
> > +
> > + clk_disable_unprepare(phy->apbclk);
> > +
> > + return 0;
> > +}
> > +
> > +static int fsl_samsung_hdmi_phy_resume(struct device *dev)
> > +{
> > + struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev);
> > + int ret = 0;
> > +
> > + ret = clk_prepare_enable(phy->apbclk);
> > + if (ret) {
> > + dev_err(phy->dev, "failed to enable apbclk\n");
> > + return ret;
> > + }
> > +
> > + if (phy->cur_cfg)
> > + ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg);
> > +
> > + return ret;
> > +
> > +}
> > +#endif
>
> we can drop this #ifdef and use __maybe annontation for pm ops
>
> > +
> > +static const struct dev_pm_ops fsl_samsung_hdmi_phy_pm_ops = {
> > + SET_RUNTIME_PM_OPS(fsl_samsung_hdmi_phy_suspend,
> > + fsl_samsung_hdmi_phy_resume, NULL)
> > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > + pm_runtime_force_resume)
> > +};
> > +
> > +static const struct of_device_id fsl_samsung_hdmi_phy_of_match[] = {
> > + {
> > + .compatible = "fsl,imx8mp-hdmi-phy",
> > + }, {
> > + /* sentinel */
> > + }
> > +};
> > +MODULE_DEVICE_TABLE(of, fsl_samsung_hdmi_phy_of_match);
> > +
> > +static struct platform_driver fsl_samsung_hdmi_phy_driver = {
> > + .probe = fsl_samsung_hdmi_phy_probe,
> > + .remove = fsl_samsung_hdmi_phy_remove,
> > + .driver = {
> > + .name = "fsl-samsung-hdmi-phy",
> > + .of_match_table = fsl_samsung_hdmi_phy_of_match,
> > + .pm = &fsl_samsung_hdmi_phy_pm_ops,
> > + },
> > +};
> > +module_platform_driver(fsl_samsung_hdmi_phy_driver);
> > +
> > +MODULE_AUTHOR("Sandor Yu <Sandor.yu@xxxxxxx>");
> > +MODULE_DESCRIPTION("SAMSUNG HDMI 2.0 Transmitter PHY Driver");
> > +MODULE_LICENSE("GPL v2");
> > --
> > 2.43.0
>
> --
> ~Vinod