Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt
From: Linus Walleij
Date: Wed Jan 31 2024 - 02:38:03 EST
On Wed, Jan 31, 2024 at 7:25 AM Yan Zhao <yan.y.zhao@xxxxxxxxx> wrote:
> This is a tiny fix to pfn_to_virt() for some platforms.
>
> The original implementaion of pfn_to_virt() takes PFN instead of PA as the
> input to macro __va, with PAGE_SHIFT applying to the converted VA, which
> is not right under most conditions, especially when there's an offset in
> __va.
Ooops that's right, I wonder why I got it wrong.
Arithmetic made it not regress :/
Thank you so much for fixing this Yan!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Arnd: I think you can take most of them through the arch tree.
Yours,
Linus Walleij