Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
From: Krzysztof Kozlowski
Date: Wed Jan 31 2024 - 03:33:00 EST
On 31/01/2024 09:25, Henrik Grimler wrote:
> Hi Krzysztof,
>
> On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote:
>> On 30/01/2024 21:40, Henrik Grimler wrote:
>>> Sort all node properties according to dts coding style guidelines, to
>>> make dtsi easier to follow.
>>>
>>> Signed-off-by: Henrik Grimler <henrik@xxxxxxxxxx>
>>> ---
>>> .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++-----------
>>> 1 file changed, 11 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> index f525b2f5e4e0..0c1aeafc025b 100644
>>> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> @@ -103,8 +103,8 @@ &cpu4 {
>>> };
>>>
>>> &gpu {
>>> - status = "okay";
>>> mali-supply = <&buck4_reg>;
>>> + status = "okay";
>>
>> Such changes should come from a tool, but since we do not have them, I
>> don't want to bother with properties re-shuffling.
>
> Noted, thanks. I will drop this patch and send a v2 in a few hours.
No need for v2, unless some other comments pop up. I will just apply #2
and #3 from this set.
Best regards,
Krzysztof