Re: [PATCH v1 1/2] perf tsc: Add missing newlines to debug statements

[James Clark]

On 31/01/2024 06:30, Ian Rogers wrote:
> It is assumed that debug statements always print a newline, fix two
> missing ones.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> This patch was inspired by bad debug output in:
> https://lore.kernel.org/linux-perf-users/CAGjhMsg_bVKJ_zfsLUR32+oZwGDr3OiBHV_BJ3QtFjyKAs7Sgg@xxxxxxxxxxxxxx/
> ---
>  tools/perf/arch/x86/util/tsc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/arch/x86/util/tsc.c b/tools/perf/arch/x86/util/tsc.c
> index 9b99f48b923c..e2d6cfe21057 100644
> --- a/tools/perf/arch/x86/util/tsc.c
> +++ b/tools/perf/arch/x86/util/tsc.c
> @@ -33,7 +33,7 @@ static double cpuinfo_tsc_freq(void)
>  
>  	cpuinfo = fopen("/proc/cpuinfo", "r");
>  	if (!cpuinfo) {
> -		pr_err("Failed to read /proc/cpuinfo for TSC frequency");
> +		pr_err("Failed to read /proc/cpuinfo for TSC frequency\n");
>  		return NAN;
>  	}
>  	while (getline(&line, &len, cpuinfo) > 0) {
> @@ -48,7 +48,7 @@ static double cpuinfo_tsc_freq(void)
>  	}
>  out:
>  	if (fpclassify(result) == FP_ZERO)
> -		pr_err("Failed to find TSC frequency in /proc/cpuinfo");
> +		pr_err("Failed to find TSC frequency in /proc/cpuinfo\n");
>  
>  	free(line);
>  	fclose(cpuinfo);


Reviewed-by: James Clark <james.clark@xxxxxxx>