Re: [PATCH v1] perf/hx_arm_ni: Support uncore ARM NI-700 PMU

[Yang Jialong 杨佳龙]

在 2024/1/30 17:23, Rob Herring 写道:
> On Tue, 30 Jan 2024 16:17:43 +0800, JiaLong.Yang wrote:
> > This code is based on uncore PMUs arm_smmuv3_pmu and arm-cmn.
> > One ni-700 can have many clock domains. Each of them has only one PMU.
> > Here one PMU corresponds to one 'struct ni_pmu' instance.
> > PMU name will be ni_pmu_N_M, which N means different NI-700s and M means
> > different PMU in one NI-700. If only one NI-700 found in NI-700, name will
> > be ni_pmu_N.
> > Node interface event name will be xxni_N_eventname, such as asni_0_rdreq_any.
> > There are many kinds of type of nodes in one clock domain. Also means that
> > there are many kinds of that in one PMU. So we distinguish them by xxni string.
> > Besides, maybe there are many nodes have same type. So we have number N in
> > event name.
> > By ni_pmu_0_0/asni_0_rdreq_any/, we can pinpoint accurate bus traffic.
> > Example1: perf stat -a -e ni_pmu_0_0/asni_0_rdreq_any/,ni_pmu_0_0/cycles/
> > EXample2: perf stat -a -e ni_pmu_0_0/asni,id=0,event=0x0/
> >
> > Signed-off-by: JiaLong.Yang <jialong.yang@xxxxxxxxxxxx>
> > ---
> > If I should send Doc*/bindings/perf/*.yaml seperately?
> >
> >   .../bindings/perf/hx,c2000-arm-ni.yaml        |   58 +
> >   .../devicetree/bindings/vendor-prefixes.yaml  |    2 +
> >   MAINTAINERS                                   |    6 +
> >   drivers/perf/Kconfig                          |   10 +
> >   drivers/perf/Makefile                         |    1 +
> >   drivers/perf/hx_arm_ni.c                      | 1308 +++++++++++++++++
> >   6 files changed, 1385 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.yaml
> >   create mode 100644 drivers/perf/hx_arm_ni.c
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.yaml:54:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
>
> dtschema/dtc warnings/errors:
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.example.dts'
> Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.yaml:54:1: found a tab character where an indentation space is expected
> make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.example.dts] Error 1
> make[2]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.yaml:54:1: found a tab character where an indentation space is expected
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/perf/hx,c2000-arm-ni.yaml: ignoring, error parsing file
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240130081745.13750-1-jialong.yang@xxxxxxxxxxxx
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

Done.

>