Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

[AngeloGioacchino Del Regno]

Il 31/01/24 13:25, Jiaxin Yu (俞家鑫) ha scritto:
> On Wed, 2024-01-31 at 12:42 +0100, AngeloGioacchino Del Regno wrote:
> > Il 03/08/23 21:33, Mark Brown ha scritto:
> > > On Thu, Aug 03, 2023 at 07:20:15AM +0000, Jiaxin Yu (俞家鑫) wrote:
> > >
> > > > I agree with you, in fact the speaker is indeed doing this way.
> > > > But
> > > > about the hdmi that on the board, I did not find a defination
> > > > link
> > > > snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to replace. The
> > > > purpose
> > > > is to control it link speaker. Or what do you suggest I should
> > > > do?
> > >
> > > I think the sensible thing here is to define a DIGITAL_OUTPUT()
> > > which
> > > can be used for HDMI, S/PDIF and anything else that comes up and
> > > isn't
> > > clearly wrong like reusing one of the analog descriptions is.
> >
> > Hello Jiaxin,
> >
> > the MT8186 Corsola Chromebooks are broken upstream without this
> > series.
> >
> > Are you still interested in upstreaming this one?
> >
> > Thanks,
> > Angelo
>
> Hello Angelo,
>
> No, I'm still interesting in upstream this series. It's just that I
> have less time recently. I'm considering revisiting this issue next
> mouth. Do you have any suggestions for this?

Nothing on top of Mark's suggestions.

Angelo