Re: [PATCH] of: unittest: Fix compile in the non-dynamic case

From: Rob Herring
Date: Wed Jan 31 2024 - 15:32:27 EST



On Mon, 29 Jan 2024 20:25:56 +0100, Christian A. Ehrhardt wrote:
> If CONFIG_OF_KOBJ is not set, a device_node does not contain a
> kobj and attempts to access the embedded kobj via kref_read break
> the compile.
>
> Replace affected kref_read calls with a macro that reads the
> refcount if it exists and returns 1 if there is no embedded kobj.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401291740.VP219WIz-lkp@xxxxxxxxx/
> Fixes: 4dde83569832 ("of: Fix double free in of_parse_phandle_with_args_map")
> Signed-off-by: Christian A. Ehrhardt <lk@xxxxxxx>
> ---
> drivers/of/unittest.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>

Applied, thanks!