回复: [v2] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Changhuang Liang]

Hi, Conor

> On Tue, Jan 30, 2024 at 12:25:09AM -0800, Changhuang Liang wrote:
> > Add camera subsystem nodes for the StarFive JH7110 SoC. They contain
> > the imx219, dphy-rx, csi2rx, camss nodes.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> > ---
> >  .../jh7110-starfive-visionfive-2.dtsi         | 103
> ++++++++++++++++++
> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  67 ++++++++++++
> >  2 files changed, 170 insertions(+)
> >
> > diff --git
> > a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > index b89e9791efa7..e0027bb379ef 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> > @@ -30,6 +30,37 @@ cpus {
> >  		timebase-frequency = <4000000>;
> >  	};
> >
> > +	imx219_clk: imx219-clock {
> > +		compatible = "fixed-clock";
> > +		clock-output-names = "imx219_clk";
> > +		clock-frequency = <24000000>;
> > +		#clock-cells = <0>;
> > +	};
> 
> Why do you need an output name here?

The output name can be unnecessary. 

> Also, where does this clock come from? Is it an oscillator on the board?
> 

This clock come from imx219, not the VisionFive 2 board.

regards
Changhuang