Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function

From: Mika Westerberg
Date: Fri Feb 09 2024 - 00:45:01 EST

Next message: Auditya Bhattaram: "Re: [PATCH v3] soc: qcom: mdt_loader: Add Upperbounds check for program header access"
Previous message: Anshuman Khandual: "[PATCH] mm/hugetlb: Move page order check inside hugetlb_cma_reserve()"
In reply to: Krzysztof Kozlowski: "[PATCH] gpio: constify opaque pointer in gpio_device_find() match function"
Next in thread: Linus Walleij: "Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Feb 08, 2024 at 09:27:04PM +0100, Krzysztof Kozlowski wrote:
> The match function used in gpio_device_find() should not modify the
> contents of passed opaque pointer, because such modification would not
> be necessary for actual matching and it could lead to quite unreadable,
> spaghetti code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Next message: Auditya Bhattaram: "Re: [PATCH v3] soc: qcom: mdt_loader: Add Upperbounds check for program header access"
Previous message: Anshuman Khandual: "[PATCH] mm/hugetlb: Move page order check inside hugetlb_cma_reserve()"
In reply to: Krzysztof Kozlowski: "[PATCH] gpio: constify opaque pointer in gpio_device_find() match function"
Next in thread: Linus Walleij: "Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]