Re: [PATCH 3/6] rust: rbtree: add `RBTreeIterator`

[Alice Ryhl]

On Mon, Feb 5, 2024 at 4:50 PM <mattgilbride@xxxxxxxxxx> wrote:
>
> From: Wedson Almeida Filho <wedsonaf@xxxxxxxxx>
>
> - Add Iterator implementation (`RBTreeIterator`) for `RBTree`, allowing
>   iteration over (key, value) pairs in key order.
> - Add individual `keys()` and `values()` functions to iterate over keys
>   or values alone.
> - Update doctests to use iteration instead of explicitly getting items.
>
> Iteration is needed by the binder driver to enumerate all values in a
> tree for oneway spam detection [1].
>
> Link: https://lore.kernel.org/rust-for-linux/20231101-rust-binder-v1-17-08ba9197f637@xxxxxxxxxx/ [1]
> Signed-off-by: Wedson Almeida Filho <wedsonaf@xxxxxxxxx>
> Signed-off-by: Matt Gilbride <mattgilbride@xxxxxxxxxx>

I have looked at these bindings many times over the past year. They
look good to me.

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

These abstractions have been very heavily exercised by the Rust Binder
driver.

Tested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>